Re: [xml] VC6, STL and VALID.H header error during compilation (posible patch)



These are the patches I generated using this command (with cygwin):

diff -Naur libxml\valid.h libxml.new\valid.h > valid.h.patch
diff -Naur libxml\xmlregexp.h libxml.new\xmlregexp.h > xmlregexp.h.patch

I espect this can help.

Regards,

Daniel Veillard wrote:

On Thu, Oct 27, 2005 at 01:16:00PM +0200, Samuel Díaz García wrote:

Daniel, I don't want to discuss anythink about this case because I think the problem were a posible error writing any post in english.


  No problem, the discussion it generated is not bad, it's good,
even if it doesn't apply well to your specific case.


All this "discuss" why? Because I found an especific problem using the headers under certain circumstances? My idea were to say all the problem and a posible solution, not to claim a patch (I solved the problem with my own hands, not waiting somebody to do the job for me). I think a patch in a very stable project (like libxml2) must be make by anyone experienced to don't produce colateral errors in another platforms.


  No, I will review your patch if you provide one. But I can't generate
it because I have no way to reproduce your problem and verify what I did
fixed it.


I think I done the correct when sent the info about the problem, allowing another users know the issue and others, those know how to patch correctly the sources, know the posible solution and if somebody can and wants, put the patch.


That would be true if this was on platforms others use. I don't use VC6 or stl, and don't know anybody else who does.


And about the other topics I prefer to say only that a community is formed by users, and all them contribute with they can: knowledge, bugs reports, explanations, questions, answers, money, patches, time, etc...


  In that case you must contribute the knowledge of your specific part
which we don't have. That means come with a least a basic patch. The patch
will be reviewed in any way.


The community is the heart of the project, and we are here to make the project better, not to make it worse.


  Right, but I don't see how we got it worse...

Daniel


--
   Samuel Díaz García
    Director Gerente
ArcosCom Wireless, S.L.L.

CIF: B11828068
c/ Romero Gago, 19
Arcos de la Frontera
11630 - Cadiz

http://www.arcoscom.com

mailto:samueldg arcoscom com
msn: samueldg arcoscom com

Móvil: 651 93 72 48
Tlfn.: 956 70 13 15
Fax:   956 70 34 83
--- libxml\valid.h      2005-07-27 22:59:38.000000000 +0200
+++ libxml.new\valid.h  2005-10-26 10:39:58.000000000 +0200
@@ -410,7 +410,7 @@
 
 XMLPUBFUN int XMLCALL          
                xmlValidGetPotentialChildren(xmlElementContent *ctree,
-                                        const xmlChar **list,
+                                        const xmlChar **_list,
                                         int *len,
                                         int max);
 
--- libxml\xmlregexp.h  2005-08-23 19:22:40.000000000 +0200
+++ libxml.new\xmlregexp.h      2005-10-26 10:41:38.000000000 +0200
@@ -183,12 +183,12 @@
 XMLPUBFUN int XMLCALL
                        xmlExpGetLanguage(xmlExpCtxtPtr ctxt,
                                         xmlExpNodePtr expr,
-                                        const xmlChar**list,
+                                        const xmlChar**_list,
                                         int len);
 XMLPUBFUN int XMLCALL
                        xmlExpGetStart  (xmlExpCtxtPtr ctxt,
                                         xmlExpNodePtr expr,
-                                        const xmlChar**list,
+                                        const xmlChar**_list,
                                         int len);
 XMLPUBFUN xmlExpNodePtr XMLCALL
                        xmlExpStringDerive(xmlExpCtxtPtr ctxt,

Attachment: samueldg.vcf
Description: Vcard



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]