Re: [xml] Some tarball questions



Daniel Veillard wrote:
  Yes that's something I wonder about. Except differences
in configuration option, it's bizarre. One possibility might
be that the order of the functions is not the same which can come
from the order of the functions in the hash tables, which can be
python version dependant but will not change the semantic of the
generated file.

This is exactly what happens, after a deeper search.

Anyway, I worked out something (attached to this mail) that doesn't change anything for you and solves a part of my problem, while being more automake friendly, even though it doesn't bring full consistency.

Basically, the CLEANFILES thing is the automake way of doing what you did with your clean target override, and gets used in *all* the clean targets (including distclean), contrary to the clean target override (distclean doesn't call clean). Note that I added the libxml2class.txt file in the GENERATED list because it is actually generated and did not get removed properly.

Also note that it doesn't change the libxml2-py.c file problem, and that a make distclean still removes much more that would be included in the tarball by a make dist, but i'm trying to take a deeper look at these issues.

Sorry if you felt bothered about the whole issue, I'll try to be more explicit next time, though my first approach tends to be to check if developpers know about some issues before look deeper into the thing before realizing it was already known, but just kept that way for some reason...

Mike
--- libxml2-2.6.8/python/Makefile.am    2003-12-21 20:01:40.000000000 +0900
+++ libxml2-2.6.8.new/python/Makefile.am        2004-04-14 22:10:15.000000000 +0900
@@ -50,10 +50,13 @@
 GENERATE = generator.py
 API_DESC = $(top_srcdir)/doc/libxml2-api.xml $(srcdir)/libxml2-python-api.xml
 GENERATED= $(srcdir)/libxml2class.py \
+           $(srcdir)/libxml2class.txt \
            $(srcdir)/libxml2-export.c \
           $(srcdir)/libxml2-py.c \
           $(srcdir)/libxml2-py.h
 
+CLEANFILES= $(GENERATED) gen_prog libxml2.py
+
 $(GENERATED): gen_prog
 
 gen_prog: $(srcdir)/$(GENERATE) $(API_DESC)
@@ -67,7 +70,3 @@
 endif
 tests test: all
        cd tests && $(MAKE) tests
-
-clean:
-       rm -f $(GENERATED) *.o _libxml.so *.pyc libxml2.py gen_prog
-


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]