RE: [xml] Windows threading issues

Thanks.  I've just found a problem with those patches: threads.c won't build
on Windows if threading is enabled but compiler TLS is not, LIBXML_STATIC is
defined, and LIBXML_STATIC_FOR_DLL is not.  (Got that?)

Attached is a third patch to fix the problem.  I think I got this right, but
Stephane, holler if you think otherwise!

-----Original Message-----
From: Daniel Veillard [mailto:veillard redhat com] 
Sent: Tuesday, October 07, 2003 4:05 PM
To: Jesse Pelton
Cc: xml gnome org
Subject: Re: [xml] Windows threading issues

On Tue, Oct 07, 2003 at 03:51:20PM -0400, Jesse Pelton wrote:
Back in July, Stéphane Bidoul and I developed a couple of 
patches to address
some Windows threading issues (see 
et al).  After he
got back from vacation, Igor expressed his intent to commit 
them (both, I
think), but I think he forgot about them.  I'm finally 
upgrading to the
latest libxml, and the changes aren't there.

Can these patches be committed?  They still appear to be 
valid.  (At least,
patch doesn't fail, and the resulting file compiles.)  The 
second patch must
be applied over the first.

  Okay, applied both, it seems they only affect Windows build with the
TLS threads support. I will commit them later when my tree is 
back in shape,

Attachment: diff.out
Description: Binary data

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]