Re: [xml] WXS patches

[Daniel Veillard <veillard redhat com>]

On Thu, Apr 03, 2003 at 09:31:52PM -0600, Charles Bozeman wrote:
> I started to make what I thought was a simple fix and ended up finding
> more problems with WXS date types.

  Okay thanks for working on this and sorry for the delay,

> xmlschemas.c
> Changed to set ctxt->err and print message when type validation fails on
> restricted types. Sets ctxt->err and prints message when facet
> validation fails.

  Okay, but I also had to add XML_SCHEMAS_ERR_FACET in xmlschemas.h

> xmlschemastypes.c
> gMonthDay values with a time zone offset were failing validation (i.e.
> --02-28-06:00) so I fixed that. Also added verification of the month and
> day values for gMonthDay (i.e. --02-30 should not validate).
> refactored duration parsing to be a tad more efficient.
> fixed a warning in xmlSchemaValAtomicType.

  okay, I just renamed the loacl variable rewind into rewnd
to avoid a warning, since rewind is part of ANSI-C

> date_0.xsd, date_0.xml, dur_0.xsd, dur_0.xml
> The above changes exposed errors in my date and duration regression
> tests, so I fixed them.

  applied too, thanks

> I still need to update the EXSLT date code when I get time.

  yup :-) ... maybe some of this code could be made conditional if 
the associated functions are availble from libxml2 ...

> The context diff patches are against the code in CVS. Let me know if
> there are any problems.

   basically just the include/libxml/xmlschemas.h patch missing, if the
only change was adding XML_SCHEMAS_ERR_FACET then that's done.

   thanks a lot,

Daniel

-- 
Daniel Veillard      | Red Hat Network https://rhn.redhat.com/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/