Re: [Tracker] [PATCH] TST improvements, ...
- From: Calvin Walton <calvin walton gmail com>
- To: Tshepang Lekhonkhobe <tshepang gmail com>
- Cc: Tracker mailing list <tracker-list gnome org>
- Subject: Re: [Tracker] [PATCH] TST improvements, ...
- Date: Sat, 15 May 2010 19:05:37 -0400
On Wed, 2010-05-05 at 13:46 +0200, Tshepang Lekhonkhobe wrote:
On Tue, May 4, 2010 at 12:29, Martyn Russell <martyn lanedo com> wrote:
38 - some clean-ups and consistency fixes (metadata tile)
You use '%s' for URIs, please don't we use \"%s\" everywhere else in the
code base and also it breaks for URIs which use ' in their name.
We usually escape strings too before using them there, but I presume the
URI came from Tracker so it should already be escaped.
If you can fix those ' vs " issues, I will commit it.
How do I do this other than reverting and redoing the patch?
What I did was revert the patch and then re-apply, fix the issues, and
commit. Is a better workflow (maybe git provides batteries for this
A better way to do this is simply to make the changes with the patch
applied and committed. Then use 'git add' as if you were making a new
commit, but use 'git commit --amend' to update the previous commit
instead of creating a new one.
Calvin Walton <calvin walton gmail com>
] [Thread Prev