Re: [Tracker] [PATCH] TST improvements, ...



On Tue, May 4, 2010 at 12:29, Martyn Russell <martyn lanedo com> wrote:
38 - some clean-ups and consistency fixes (metadata tile)

You use '%s' for URIs, please don't we use \"%s\" everywhere else in the
code base and also it breaks for URIs which use ' in their name.

We usually escape strings too before using them there, but I presume the
URI came from Tracker so it should already be escaped.

If you can fix those ' vs " issues, I will commit it.

How do I do this other than reverting and redoing the patch?

What I did was revert the patch and then re-apply, fix the issues, and
commit. Is a better workflow (maybe git provides batteries for this
kinda thing)?


-- 
my place on the web:
floss-and-misc.blogspot.com



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]