Re: [Tracker] [PATCH] TST improvements, ...

[Tshepang Lekhonkhobe <tshepang gmail com>]

Thanks for committing.

On Tue, May 4, 2010 at 12:29, Martyn Russell <martyn lanedo com> wrote:
> > 38 - some clean-ups and consistency fixes (metadata tile)
>
> You use '%s' for URIs, please don't we use \"%s\" everywhere else in the
> code base and also it breaks for URIs which use ' in their name.
>
> We usually escape strings too before using them there, but I presume the
> URI came from Tracker so it should already be escaped.
>
> If you can fix those ' vs " issues, I will commit it.

How do I do this other than reverting and redoing the patch?

> > 39 - fix a segfault
>
> Looks good, but doesn't commit due to 0038.

okay

> Thanks Tshepang, great patches, keep em comin' ;)

:-)


-- 
my place on the web:
floss-and-misc.blogspot.com