Re: [Tracker] [PATCH] TST improvements, ...

[Martyn Russell <martyn lanedo com>]

On Mon, 2010-05-03 at 12:51 +0200, Tshepang Lekhonkhobe wrote:
> Hi,

Hi,

> Attached are some small improvements to tracker-search-tool:
>
> 32 - fix to Jammie McCracken's email address in the copyright
>  assignment

Committed

> 35 - add a "Folders" category; rename "Office Documents" to
> "Documents" which is more accurate

Committed

> 37 - rename Music category to Audio, which is more accurate

Of course we still show "Music" in the categories list.

> 38 - some clean-ups and consistency fixes (metadata tile)

You use '%s' for URIs, please don't we use \"%s\" everywhere else in the
code base and also it breaks for URIs which use ' in their name.

We usually escape strings too before using them there, but I presume the
URI came from Tracker so it should already be escaped.

If you can fix those ' vs " issues, I will commit it.

> 39 - fix a segfault

Looks good, but doesn't commit due to 0038.

> Attached one to tracker-extract (html):
> 34 - changed nfo:Document to nfo:HtmlDocument in html extractor (maybe
> should prompt for a "tracker-control -m text/html"?) 

Committed.

We probably should ask all packages to make sure this is run in the next
version of Tracker as a post install script.

Thanks Tshepang, great patches, keep em comin' ;)

-- 
Regards,
Martyn