Re: [Tracker] [Patch] First tracker gui patch

[Jamie McCracken <jamiemcc blueyonder co uk>]

Edward Duffy wrote:

> > dunno but  best to inline the segment of code from libgnomeui?
> Probably do-able, it's just md5 stuff[1].  If only Tracker could tell
> me this! ;)
> I'm not exactly sure if nautilus way is the standard way, does Konquerer 
> and
> Thunar do it the same thing?

I would guess so as its in the spec.

MD5 code is here:
http://theory.lcs.mit.edu/~rivest/md5.c

> >
> :( I really hate tabs.  

I agree if used excessively but in moderation it should give us a good 
balance between screen space and functionality for dividing the results.

I dont mind having a "show results in seperate tabs" option if some of 
you are really against it - feel free to add.


Also, there's almost 30 services listed in
> tracker-introspec.xml...do you really want a tab for each of those?

no that bit needs to change anyhow due to translations. I would hardcode 
"All Files", "Documents", "Images", "Videos", "Text", "Development 
Files" as the services. Later on when we index emails, logs and 
applications we can add  "Conversations" and  "Applications". The rest 
are not really important enough to show.

Only tabs that have search results would be shown and I expect not more 
than half a dozen would ever be present

All strings need to be translatable for inclusion into Gnome so getting 
the services from tracker would not be ideal - it needs to be hardcoded 
using _() from :
http://developer.gnome.org/doc/API/2.0/glib/glib-I18N.html

(I dont fully understand how translations work but it has something to 
do with .po files - hopefully someone here can enlighten us)



> It's also redundant wrt to the combo box listing the services.  But, as 
> I just

It can also be used to limit the tabs that are shown (if the option 
"show results in tabs" is set)?

> wriote, with 30 serives that's too long for a combo box and a tree view 
> would
> be better..

yes we can look at that too although it might take up more screen space 
and add more clutter than tabs?

> While on the treeview subject (the tab idea did this too) it should
> show the number
> of results for each service.  Is there a way to do this currently?
> Sort of a pre-search
> that can just return a hash table of serivce to count without requiring 
> a limit?
> IIRC, the GetTags method does this...

I can write that bit later.

> > Also please put back the toolbar under the tab which should have the
> > next/previous buttons and some new stuff:
> >
> > 1) a small combo box prefilled with no of search results to display in a
> > page (I suggest 10,20,30,50,100)
> >
> > 2) two mutually exclusive buttons (ensure one is always "down") for
> > selecting a treeview or iconview display
> Sounds like clutter and should be in a preference dialog, IMO.  I
> can't possible see myself performing a search showing 20 results at a
> time, 50 for the next search, and then 10 on the third.  Same goes for
> switching between treeview or iconview.

not really - spotlight allows this switching between views (so does all 
the file managers). We need a toolbar for showing next/previous buttons 
anyhow so theres plenty of room for the others

Yes, we can default the values to their previously saved state

> > please fix above and I will be happy to apply
> >
> > Thanks for your work on this - its starting to look really nice :)
>
> Thank you..it may be a day or two before I can work on it again...it 
> seems I
> only get time to work on it in bursts.

great look forward to seeing it! (please also keep the coding style the 
same as tracker's - use tab indentation and always use curly braces for 
control flow constructs)

> BTW, I brought up preferences earlier in this email...what's the
> stance on GConf?
> Would a ~/.Tracker/tracker-gui.cfg GKeyFile be preferable?

I would like to have optional gconf (just as gtk is optional) to both 
tracker and and the gui. It cant be compulsory as it might put off XFCE.

This is not urgent however.





--
Mr Jamie McCracken
http://jamiemcc.livejournal.com/