Re: [Tracker] [Patch] First tracker gui patch

["Edward Duffy" <eduffy gmail com>]

On 9/14/06, Jamie McCracken <jamiemcc blueyonder co uk> wrote:
> Edward Duffy wrote:
> > Here's an update that will display thumbnails.  It's kind of buggy, it
> > crashes 1 out of every 3 times for me, even on the same search.  If
> > it's constantly crashing for you, comment out the pthread_create call
> > on line 286.
>
> gtk is not thread safe and will crash unless you do what it says on page:
>
> http://developer.gnome.org/doc/API/2.0/gdk/gdk-Threads.html
>
> make sure you init glib and gdk threads early on in main (and before you
> call glade)
>
> whenever you update a gtk widget in a thread you must surround it with
> GDK_THREADS_ENTER and GDK_THREADS_LEAVE
>
> Also we should use the glib encapsulation of threads and not pthread
> directly.
Ok, I'll have to look more into this.  I've never mixed gtk and
threads ( I didn't realize glib wrapped that too)

> >
> > Also, it depends on libgnomeui... is there a desktop agnostic way to
> > get a file's thumbnail?
>
> dunno but  best to inline the segment of code from libgnomeui?
Probably do-able, it's just md5 stuff[1].  If only Tracker could tell
me this! ;)
I'm not exactly sure if nautilus way is the standard way, does Konquerer and
Thunar do it the same thing?

[1] http://cvs.gnome.org/viewcvs/libgnomeui/libgnomeui/gnome-thumbnail.c?view=markup

> >
> > So, here's the new patch (that doesn't depend on the previous one I
> > sent), and a screenshot to show that it can work.
> >
>
> its nice but please dont get rid of the tabs just yet. (I would like to
> see them in action before deciding which way to go)
:( I really hate tabs.  Also, there's almost 30 services listed in
tracker-introspec.xml...do you really want a tab for each of those?
It's also redundant wrt to the combo box listing the services.  But, as I just
wriote, with 30 serives that's too long for a combo box and a tree view would
be better..
While on the treeview subject (the tab idea did this too) it should
show the number
of results for each service.  Is there a way to do this currently?
Sort of a pre-search
that can just return a hash table of serivce to count without requiring a limit?
IIRC, the GetTags method does this...

> Also please put back the toolbar under the tab which should have the
> next/previous buttons and some new stuff:
>
> 1) a small combo box prefilled with no of search results to display in a
> page (I suggest 10,20,30,50,100)
>
> 2) two mutually exclusive buttons (ensure one is always "down") for
> selecting a treeview or iconview display
Sounds like clutter and should be in a preference dialog, IMO.  I
can't possible see myself performing a search showing 20 results at a
time, 50 for the next search, and then 10 on the third.  Same goes for
switching between treeview or iconview.

> please fix above and I will be happy to apply
>
> Thanks for your work on this - its starting to look really nice :)

Thank you..it may be a day or two before I can work on it again...it seems I
only get time to work on it in bursts.

BTW, I brought up preferences earlier in this email...what's the
stance on GConf?
Would a ~/.Tracker/tracker-gui.cfg GKeyFile be preferable?


> --
> Mr Jamie McCracken
> http://jamiemcc.livejournal.com/