Re: [Tracker] [Patch] First tracker gui patch

[Jamie McCracken <jamiemcc blueyonder co uk>]

Edward Duffy wrote:
> Here's an update that will display thumbnails.  It's kind of buggy, it
> crashes 1 out of every 3 times for me, even on the same search.  If
> it's constantly crashing for you, comment out the pthread_create call
> on line 286.

gtk is not thread safe and will crash unless you do what it says on page:

http://developer.gnome.org/doc/API/2.0/gdk/gdk-Threads.html

make sure you init glib and gdk threads early on in main (and before you 
call glade)

whenever you update a gtk widget in a thread you must surround it with
GDK_THREADS_ENTER and GDK_THREADS_LEAVE

Also we should use the glib encapsulation of threads and not pthread 
directly.

> Also, it depends on libgnomeui... is there a desktop agnostic way to
> get a file's thumbnail?

dunno but  best to inline the segment of code from libgnomeui?
> So, here's the new patch (that doesn't depend on the previous one I
> sent), and a screenshot to show that it can work.

its nice but please dont get rid of the tabs just yet. (I would like to 
see them in action before deciding which way to go)

Also please put back the toolbar under the tab which should have the 
next/previous buttons and some new stuff:

1) a small combo box prefilled with no of search results to display in a 
page (I suggest 10,20,30,50,100)

2) two mutually exclusive buttons (ensure one is always "down") for 
selecting a treeview or iconview display


please fix above and I will be happy to apply

Thanks for your work on this - its starting to look really nice :)

--
Mr Jamie McCracken
http://jamiemcc.livejournal.com/