Re: pending patches

[Philip Van Hoof <spam pvanhoof be>]

Patch reviews for 10 and 12

Patch #10:

* tny_camel_send_queue_get_folders must support and respect the
  TnyFolderStoreQuery 

* In tny_camel_send_queue_create_folder_async_callback you find:

  + // tny_lockable_lock (info->session->priv->ui_lock);

  Why is the TnyLockable disabled here?


Patch #12:

 * Please use g_object_ref in the constructor, and unref in the finalize
   or dispose if not NULL and init as NULL in init, for priv->ui_locker.

   + priv->ui_lock = ui_locker;


On Thu, 2008-10-09 at 19:04 +0200, martin bonnin wrote:
> 
> 
> 2008/10/9 Philip Van Hoof <spam pvanhoof be>
>         On Thu, 2008-10-09 at 18:34 +0200, Sergio Villar Senin wrote:
>         > Hi Martin,
>         >
>         > martin bonnin escribiu:
>         > > Hi,
>         > >
>         > > 2008/10/9 Philip Van Hoof <spam pvanhoof be
>         <mailto:spam pvanhoof be>>
>         > >
>         > >     Would it be possible to make all of the approved ones
>         apply without
>         > >     failed hunks?
>         > >
>         
>         
>         These patches have been committed:
>         
>         [PATCH_02_18]_Give_tny_folder_store_get_folders_a_refresh_parameter.patch
>         
>         [PATCH_03_18]_New_observer_behaviour.patch
>         
>         [PATCH_05_18]_Attempt_to_fix_the_queue_account_refcount.patch
>         
>         [PATCH_06_18]_Fix_ref_leak_with_the_iter_store.patch
>         
>         [PATCH_07_18]Add_tny_camel_queue_stop.patch
>         
>         [PATCH_11_18]_Add_tny_camel_send_queue_new_with_folders.patch
>         
>         [PATCH_15_18]_In_TnyCamelFolder_don_t_emit_folder_store_change.patch
>         
>         
>         Let's get the remaining ones reviewed and then committed too
> 
> 
> Remaining are patches 10/18 and 12/18. They both add an observer-mixin
> object, which is to decide whether it has to be public or not. I don't
> know the details good enough to decide. What I can tell is that I have
> been using the MergeFolderStore without problem for some time now.
> 
> Regards,
> 
> -- 
> Martin
> 
> 
> 
> _______________________________________________
> tinymail-devel-list mailing list
> tinymail-devel-list gnome org
> http://mail.gnome.org/mailman/listinfo/tinymail-devel-list
-- 
Philip Van Hoof, freelance software developer
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
http://pvanhoof.be/blog
http://codeminded.be