Re: Patch: fix the progress information when refreshing an imap folder



Hello,

   After a discussion on the irc, Sergio preferred this patch to be
reverted. It's now reverted in svn. Attached is a patch that tries to
better specify the behavior of refresh status messages.

Regards,

-- 
Martin
Index: libtinymailui-gtk/tny-gtk-header-list-model.c
===================================================================
--- libtinymailui-gtk/tny-gtk-header-list-model.c	(révision 3820)
+++ libtinymailui-gtk/tny-gtk-header-list-model.c	(copie de travail)
@@ -1255,6 +1255,9 @@
  * @status_callback: (null-ok): a #TnyStatusCallback or NULL
  * @user_data: (null-ok): user data for the callbacks
  *
+ * status_callback() will be called during this operation. It is guaranteed that the refresh 
+ * messages happen but it's not guaranteed that only refresh messages happen.
+ *
  * Set the @folder of @self where #TnyHeader instances are located
  * 
  * since: 1.0
Index: ChangeLog
===================================================================
--- ChangeLog	(révision 3821)
+++ ChangeLog	(copie de travail)
@@ -1,5 +1,9 @@
 2008-11-21  Martin Bonnin  <martinbonnin gmail com>
  
+	Add some documentation about the behaviour of tny_folder_refresh_async()
+
+2008-11-21  Martin Bonnin  <martinbonnin gmail com>
+ 
 	* revert last changeset:
 	We want this to be fixed a better way
 
Index: libtinymail/tny-folder.c
===================================================================
--- libtinymail/tny-folder.c	(révision 3820)
+++ libtinymail/tny-folder.c	(copie de travail)
@@ -843,6 +843,9 @@
  * will get notified of new header additions. #TnyFolderMonitor copes with those
  * by publishing them to #TnyList instances, like a #TnyGtkHeaderListModel.
  *
+ * status_callback() will be called during this operation. It is guaranteed that the refresh 
+ * messages happen but it's not guaranteed that only refresh messages happen.
+ * 
  * Example:
  * <informalexample><programlisting>
  * static void


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]