RE: Patch: do not convert all text parts to UTF-8

[Philip Van Hoof <spam pvanhoof be>]

Which is why I asked Sergio to verify this :)

On Wed, 2008-08-13 at 09:26 +0300, Dirk-Jan Binnema nokia com wrote:
> Hi all,
> 
> Hmmmm.... one comment, do we have some example message that fails
> without this patch?
> And are there mails that worked before, but could break with this?
> 
> Potentially, the patch could change the behaviour for many mails, so I
> guess it's
> important to make sure it does not break anything. 
> 
> Best wishes,
> Dirk 
> 
> > -----Original Message-----
> > From: tinymail-devel-list-bounces gnome org 
> > [mailto:tinymail-devel-list-bounces gnome org] On Behalf Of 
> > ext Philip Van Hoof
> > Sent: Tuesday, August 12, 2008 19:15
> > To: Sergio Villar Senin
> > Cc: tinymail-devel-list
> > Subject: Re: Patch: do not convert all text parts to UTF-8
> > 
> > 
> > ps. I'm ok with Sergio committing this for you, Thomas.
> > 
> > On Tue, 2008-08-12 at 16:41 +0200, Sergio Villar Senin wrote:
> > > Thomas Monjalon escribiu:
> > > > Hi all,
> > > > 
> > > > Tinymail converts all text parts to UTF-8.
> > > > But some texts could be altered if they are converted.
> > > > For example, an HTML document has its own defined 
> > charset. If we convert the 
> > > > document without modify its charset definition, it will 
> > be bad displayed.
> > > > 
> > > > Here are the standards text/* mime types:
> > > > 	http://www.iana.org/assignments/media-types/text
> > > > 
> > > > I think it's better to convert only text/plain parts.
> > > 
> > > The patch is OK for me as well, if you don't have commit 
> > permissions I
> > > can do it for you, just send a nice ChangeLog entry.
> > > 
> > > Br
> > > 
> > > PS: sorry for being so late reviewing, but I'm quite busy ATM
> > > _______________________________________________
> > > tinymail-devel-list mailing list
> > > tinymail-devel-list gnome org
> > > http://mail.gnome.org/mailman/listinfo/tinymail-devel-list
> > > 
> > -- 
> > Philip Van Hoof, freelance software developer
> > home: me at pvanhoof dot be 
> > gnome: pvanhoof at gnome dot org 
> > http://pvanhoof.be/blog
> > http://codeminded.be
> > 
> > 
> > 
> > 
> > _______________________________________________
> > tinymail-devel-list mailing list
> > tinymail-devel-list gnome org
> > http://mail.gnome.org/mailman/listinfo/tinymail-devel-list
> > 
> _______________________________________________
> tinymail-devel-list mailing list
> tinymail-devel-list gnome org
> http://mail.gnome.org/mailman/listinfo/tinymail-devel-list
> 
-- 
Philip Van Hoof, freelance software developer
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
http://pvanhoof.be/blog
http://codeminded.be