Re: ** to GIT source users ** Some incompatibility in "StyleTab"

On Tuesday 22 February 2011 19:14:07 fuchur wrote:
> Hi,
> On Mon, 21 Feb 2011 21:03:26 +0100
> wrote Christopher Roy Bratusek <nano tuxfamily org>:
> >OK. I fixed it like:
> >
> >349   (define (before-move-resize win)
> >350     "Releas win from the tabgroup and iconify the rest from the
> >group." 351     (let* ((index (tab-window-group-index win))
> >352            (wins (tab-group-window-list (nth index tab-groups)))
> >353            (tabs (remove win (tab-group-window-list (nth index
> >tab-groups)))) 354            (default-window-animator 'none))
> >^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> >
> >So for this action the default-animator is always disabled, and the issues
> >are gone.
> >
> >Either way opaque should be fixed, to not eat that much CPU-time (not a
> >issue of your code, but the animator itself).
> Patch for tabgroup.jl. Changelog:
> Add support for maximized/unmaximized, focus-mode, gravity,
> sticky-viewpor and never-maximize.
> Improve tab-refresh-group.
> Small fix for before-move-resize.
> All what i want do to in tabgroup.jl is now ready. The select/input or
> event window should now work like a singel window without tabs. If
> (you) change "events" for the select window it happens so fast like
> without tabs, necessary changes for tabs are happens only in the
> "background". I have make sure the the select window not reframe/frame
> twice and also change window propertys or reframe/frame only once for
> tabs if it is necessary.
> Sure it is possible to remove the most hooks from tabgroup.jl, and use
> "tab-group-window-index" and integrate tabs complete in the sawish code
> but it would not be faster, all "settings change" for tabs are in the
> "background".

OK. Looks fine. Maybe some smaller jobs need to be done further (when bugs are 
encoutered), but overall it looks pretty good. (Very good compared to what we 
had before). There is one thing I thougt about recently:

As I'm sure you saw, I modifed the window-ops-menu to gray-out any options, 
that is not permitted for a window, eg: "Resize" in the menu becomes 
unclickable, when the window has fixed-size flag.

So the menu is in sync now. What is not in sync are the themes. So now I 
wonder, whether it would be a good idea, to have the themes respect the flags, 
too and gray-out (or even better don't show those buttons) accordingly?

Often heard - often said, but still valid: Thanks a lot for your work on 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]