Re: Themes for 3.0


On Sat, 20 Nov 2010 17:57:49 +0100
wrote Christopher Roy Bratusek <zanghar freenet de>:

>Am Donnerstag 04 November 2010, 21:13:37 schrieb Christopher Roy Bratusek:
>> Well after doing some testing I removed a small portion:
>> diff --git a/lisp/sawfish/wm/tabs/tabgroup.jl
>> b/lisp/sawfish/wm/tabs/tabgroup.jl index bdfc95a..cd55e5a 100644
>> --- a/lisp/sawfish/wm/tabs/tabgroup.jl
>> +++ b/lisp/sawfish/wm/tabs/tabgroup.jl
>> @@ -287,7 +287,7 @@
>>        (make-group-unsticky w)))
>>    (unless batch-mode
>> -    (add-hook 'focus-in-hook raise-tab-group)
>> +    ;(add-hook 'focus-in-hook raise-tab-group)
>>      (add-hook 'window-state-change-hook
>>                (lambda (win args)
>>                  (if (= '(sticky) args)
>> The reason why I did is pretty simple: it always raises a newly focused
>> window. That is a bad behavior, as it overrides the settings I made
>> (enter-exit, but not raising a window, unless I hit it's border (using
>> raise-tabs-on-hover)).
>> Chris
>OK. The proper fix would be to listen to focus-in, check whether the window was 
>raised, and THEN raise the group. Though I haven't yet checked, whether we 
>have something like raised-p or similar.

The focus-in-hook was complete remove by one of my last patches. With
my settings we don't need it. Do you got errors (Overlapping in the
Tabbar something like this

>Also: what do you plan on doing for tabs? I just would like to know how much 
>is still beeing done, so that I know whether I can release the RC of Sawfish 
>1.8 in December or not. (won't happen without edge-actions and tabs-ng).

I guess tab support in sawfish is at this moment only alpha.
We really always call a hook before we reframe a window,
adjustment-title in frames.jl is only a hack i think.
opaque move or resize not work correct with tabs.
Maybe someone who understand lips should take a look in tab tabgroup ...

The next two - three weeks i have not the time to work on themes or
tabs support.


GPG Fingerprint: CA3B 8204 5B3E 6D48 6D53  C116 E5BC 70D5 B8D7 B2B0

Attachment: signature.asc
Description: PGP signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]