Re: on viewport; doc review request & questions

Teika Kazura <teika lavabit com> writes:
> (to: sawfish-list cc: jeremy)

In general I prefer to have it go only to the list.  Thanks, though.  :)

> Hi, I've done some work on viewport, especially in doc. 
> 1.
> Will you have time to review info manual on viewport, especially
> dynamic viewport section? I know it's not complete, but I won't go
> much further for 1.6.

Yes, I will try to find a chance to look at that in the next few days.

> 2.
> Doc on window-absolute-position was wrong. It returns the position
> as if the window's VP is selected. Does it affect any of your code?

Ur, no, it doesn't affect my code.  I clearly wasn't paying enough
attention to what the function did when I wrote the doc string....  When
I look at the docs I'll look at that too, and window-relative-position,
since that's exactly what window-relative-position is supposed to do.

> 4.
> I've renamed viewport-offset to viewport-offset-pixel.

Why?  It was named viewport-offset to match the viewport-x-offset and
viewport-y-offset variables.  If you think it should be renamed, how
about viewport-offset-coords, and viewport-[xy]-offset-coords?  "Pixel"
in my mind suggests bits of light on the display, which isn't really
right here.  But I think viewport-offset is simplest.

> Today I asked Chris to pull my branch, so wait for a day or two. Or
> you can fetch it with:
> git remote add gitorious git gitorious org:sawfish/sawfish.git
> git fetch gitorious
> git branch --track teika gitorious/master
> git checkout teika
> You can make info by:
> makeinfo  -I . sawfish.texi -o
> in man/
> Regards,
> Teika (Teika kazura)

Jeremy Hankins <nowan nowan org>

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]