Re: [sabayon] identity crisis

[Mark McLoughlin <markmc redhat com>]

On Fri, 2005-06-17 at 16:38 -0400, John Dennis wrote:

> > 	and in editorwindow.py you'd want something like:
> 
> >         source = self.profile.get_source (source_name)
> >         if source is None:
> >             source = self.profile.get_delegate (source_name)
> 
> Done too, but I'm wondering if it's a good idea to replicated this check
> and extra call everyplace it might be needed, what do you think about
> pushing that logic up into get_source() so that all callers benefit.
> 
> Most code doesn't care if its a source or a delegate and if it does it
> can always test for it, right?

	We can't really put it in get_source() because ProfileSource and
ProfileDelegate don't have exactly the same API so ...

	(I think this is yet another indication that we'll want to re-think
this object hierarchy)

Cheers,
Mark.