Re: [Rhythmbox-devel] Patches for discussion

On Wed, 2006-02-22 at 00:44 +0100, Karsten Schmiedecke wrote:
> [Restore visibility on startup]
> Generally a nice idea, and understandable. However, my concern is that,
> even though I love Linux for its stability and all, every once in a
> while an application like the system tray crashes, not alwys restoring
> all icons when restarted. Some window managers don't even have a system
> tray (yeah, I know that in these WMs RB wouldn't get minimized anyway,
> but what if ppl use different WMs depending on what they intend to do?)
> What I'm saying is that if you minimize RB and - for whatever reason -
> lose your system tray icon, you need to be able to see the main window
> by restarting RB. So, if this gets implemented, there needs to be at
> least a command line option for explicitly showing the main window.

Rhythmbox is one of the better behaving apps in this regard, and mostly
deals with that already:
* if started with no notification area, Rhythmbox will never be hidden.
* if started when running in the NA, RB will show itself.
* if the NA disappears (removed, panel crashed) Rhythmbox will unhide
the window
* if the NA re-appears (e.g. panel restarts) RB will automatically
reinsert the tray icon.

Barring any bugs in the code, RB should never get into a state when the
window is hidden and not have a tray icon. The NA isn't currently
keyboard-accessible, but if RB starts in the tray, it can be shown by
running RB again (as Christophe asked).

> [Library Location selection UI ]
> I love the library! Especially the watching feature! (Just wanted to
> say that out loud right now.) There are times when it'd be good to
> have multiple Library locations. For example in an environment, where
> there's a global music location for all users' music plus a private
> location for a user's own music. Then again, you could solve the
> problem by creating a pseudo-library-location with links to the
> different directories containing the music.

Using links would certainly work, and with RB >= 0.9.3 it shouldn't get
stuck on recursive symlinks either. Rhythmbox has supported multiple
library locations since library watching got added, it just isn't
exposed in the UI (i.e. via gconf).

Given that the majority of people won't want or need multiple locations,
I don't think we should make it harder for them to use because of a
minority. However if we can add it in a way that doesn't annoy people
who don't want to use it, it's good for both groups.

I personally like the "additional library locations" button idea,
because it is easily ignorable by people who don't want it; they either
won't press the button, or they will press it, read the description and
then close the dialog because they don't want the feature. It also
reinforces the fact that the location selected in the main preferences
is more important, as it is the "primary" library location that would
get used for CD ripping, copying off ipods, etc.


James "Doc" Livingston
There are two ways of constructing a software design. One way is to make
it so simple that there are obviously no deficiencies. And the other way
is to make it so complicated that there are no obvious deficiencies.
    -- C.A.R. Hoare

Attachment: signature.asc
Description: This is a digitally signed message part

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]