Re: [Rhythmbox-devel] Breakage on merge branch (patch-57)

On Fri, 2005-05-06 at 03:28 +1000, James Livingston wrote:
> On Thu, 2005-05-05 at 19:08 +0200, Oliver Lemke wrote:
> > On Fri, 2005-05-06 at 02:54 +1000, James Livingston wrote:
> > > Patch-57 on the merge branch, which pulls in patch-23 of Jonathan bugs
> > > branch causes some breakage. On line 1008 of shell/rb-shell.c a
> > > parameter is passed in to rb_sourcelist_new(), when none is expected.
> > > 
> > > I'm guessing that one of Jonathan's other things which isn't included
> > > changes the definition of the function.
> > > 
> > > It works fine if you remove the parameter.
> > 
> > That's weird. It works fine here. And in source/rb-sourcelist.h you can
> > see that it requires an RBShell as a parameter. Can you check how the
> > declaration of rb_sourclist_new looks like in your copy?
> GtkWidget *     rb_sourcelist_new               (void);
> I was just having a discussion on #rhythmbox with someone who was having
> the same problem (although they were using gcc 4).
> None of the branches I've grabbed have it changed to take an argument,
> do you know when it changed?

Yes, it changed in merge-patch-57 which pulled in jonathan's bugs branch
patch 25.

* jonathan kaolin hn org--2005/rhythmbox--bugs--0.9--patch-25
   fix popups shown from source list, add one for 'new playlist' etc.
when a blank area is clicked

Can you verify that a completely new checkout of the merge branch still
contains the void param? I just tried on a remote machine updating an
existing copy and a checking out a new copy directly from my public
archive and in both cases rb_sourcelist_new expects RBShell as a
parameter. No idea what is going wrong here.

so long,

Public GPG Key:
Fingerprint: 2389 0B2C 1AA8 4E3E D5AD 3B72 00DB ABDC 73ED C558

Attachment: signature.asc
Description: This is a digitally signed message part

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]