[Rhythmbox-devel] Rhythmbox 0.9 feedback

[Ernst Persson <ernstp gmail com>]

Hi all!

Thought I'd try out the development branch from arch on Ubuntu Hoary AMD64.

Here are some comments.
The burn playlist feature is really hard to find. People who upgrade
won't notice it. Toolbar button?

Context menus. That usually means that if you right click on
something, you get a menu for that item. The source list does not
follow this. What does the HIG say?

Oh, and right clicking on the white space in the sourcelist could give
you the option to create a new playlist. What do you think?

Was there a patch to allow artists and albums to be dragged onto
existing playlist (in the source list)? Doesn't seem to work.

I needed this to compile it on AMD64:

--- orig/sources/rb-playlist-source-recorder.c
+++ mod/sources/rb-playlist-source-recorder.c
@@ -1122,7 +1122,7 @@
                                                      "This exceeds
the length of a standard audio CD.  "
                                                      "If the
destination media is larger than a standard audio CD "
                                                      "please insert
it in the drive and try again."),
-                                                   duration / 60);
+                                                   (long long
int)(duration / 60) );
                 } else if ((media_duration > 0) && (media_duration <=
duration)) {
                         message = g_strdup_printf (_("This playlist
is %" G_GINT64_FORMAT " minutes long.  "
                                                      "This exceeds
the %" G_GINT64_FORMAT " minute length of the media in the drive."),

--- orig/player/rb-recorder-gst.c
+++ mod/player/rb-recorder-gst.c
@@ -1094,8 +1094,8 @@
                              RB_RECORDER_ERROR_GENERAL,
                              _("This playlist is %lld minutes long.  "
                                "This exceeds the %lld minute length
of the media in the drive."),
-                             tracks_length / 60,
-                             media_length / 60);
+                             (long long int)(tracks_length / 60) ,
+                             (long long int)(media_length / 60) );
                 return FALSE;
         }

After moving the separator between the source list and the main list
back and forth a few times RB locked up. Could be GTK, could be RB?

Well, killing RB resulted in RB crashing at startup instead. I'd guess
it's when the whole library has been read in.
Here's some excessive backtrace from that: :-)

[0x5d65a0] [rb_remote_dbus_acquire] rb-remote-dbus.c:220 (00:48:11):
acquiring service org.gnome.Rhythmbox wi th dbus: success
[0x5d65a0] [rb_remote_dbus_acquire] rb-remote-dbus.c:228 (00:48:11):
registered session object: /org/gnome/Rh ythmbox/DBusRemote0
[0x5d65a0] [handle_cmdline] main.c:300 (00:48:11): handling command line
[0x5d65a0] [rb_shell_clipboard_entryview_changed_cb]
rb-shell-clipboard.c:517 (00:48:11): entryview changed
[0x5d65a0] [rb_shell_clipboard_sync] rb-shell-clipboard.c:353
(00:48:11): syncing clipboard
[0x5d65a0] [rb_shell_player_entry_view_changed_cb]
rb-shell-player.c:1571 (00:48:11): entry view changed
[0x5d65a0] [rb_shell_player_sync_buttons] rb-shell-player.c:1723
(00:48:11): syncing with source 0x7f9ef0
[0x5d65a0] [rb_random_play_order_get_next] rb-play-order-random.c:345
(00:48:11): choosing random entry
[0x5d65a0] [rb_shell_player_set_play_button] rb-shell-player.c:1627
(00:48:11): setting play button
[0x5d65a0] [rb_statusbar_entry_view_changed_cb] rb-statusbar.c:608
(00:48:11): entry view changed
[0x5d65a0] [rb_playlist_manager_save_playlists]
rb-playlist-manager.c:608 (00:48:11): saving the playlists
[0x5d65a0] [rb_playlist_manager_save_playlists]
rb-playlist-manager.c:611 (00:48:11): no save needed, ignorin g
[0x5d65a0] [paned_size_allocate_cb] rb-library-source.c:1151
(00:48:11): paned size allocate
[0x5d65a0] [paned_size_allocate_cb] rb-shell.c:1841 (00:48:11): paned
size allocate
[0x5d65a0] [paned_size_allocate_cb] rb-library-source.c:1151
(00:48:11): paned size allocate
[0x5d65a0] [paned_size_allocate_cb] rb-shell.c:1841 (00:48:11): paned
size allocate
[0x5d65a0] [paned_size_allocate_cb] rb-library-source.c:1151
(00:48:11): paned size allocate
[0x5d65a0] [paned_size_allocate_cb] rb-shell.c:1841 (00:48:11): paned
size allocate
[0x5d65a0] [paned_size_allocate_cb] rb-library-source.c:1151
(00:48:11): paned size allocate
[0x5d65a0] [paned_size_allocate_cb] rb-shell.c:1841 (00:48:11): paned
size allocate
[0x5d65a0] [rhythmdb_process_events] rhythmdb.c:1354 (00:48:11):
processing RHYTHMDB_EVENT_QUERY_COMPLETE
[0x5d65a0] [rhythmdb_read_leave] rhythmdb.c:724 (00:48:11): counter: 3
[0x5d65a0] [rhythmdb_process_events] rhythmdb.c:1347 (00:48:11):
processing RHYTHMDB_EVENT_THREAD_EXITED
[0x5d65a0] [rhythmdb_process_events] rhythmdb.c:1354 (00:48:11):
processing RHYTHMDB_EVENT_QUERY_COMPLETE
[0x5d65a0] [rhythmdb_read_leave] rhythmdb.c:724 (00:48:11): counter: 2
[0x5d65a0] [rhythmdb_process_events] rhythmdb.c:1354 (00:48:11):
processing RHYTHMDB_EVENT_QUERY_COMPLETE
[0x5d65a0] [rhythmdb_read_leave] rhythmdb.c:724 (00:48:11): counter: 1
[0x5d65a0] [rhythmdb_process_events] rhythmdb.c:1335 (00:48:11):
processing RHYTHMDB_EVENT_STAT

RhythmDB-ERROR **: file rhythmdb.c: line 1800 (rhythmdb_entry_set):
assertion failed: (rhythmdb_get_readonly (db) == FALSE)
aborting...
[0x77a930] [action_thread_main] rhythmdb.c:1573 (00:48:12): executing
RHYTHMDB_ACTION_STAT
ernstp zapp ~ $

Great progress anyway!
Greetings,
//ernst