Re: Some code changes wanted in Rygel

["Zeeshan Ali (Khattak)" <zeenix gmail com>]

On Mon, Sep 27, 2010 at 6:29 PM, Vincent Untz <vuntz gnome org> wrote:
>> > My understanding is that the first three commits go together. How
>> > critical are those changes?
>>
>>   The first one (206f019) fixes a leak introduced in previous release.
>> 8c0391d..14071c0 are the fixes for IOP.
>
> Ah, I hadn't see this one due to the way git log works (see below).
>
> I'm confused: the commit says "Don't set description if already set",
> but you always do a set_content(). I don't know if this is what you
> wanted?

   No, read again:

@@ -120,9 +120,7 @@ internal class Rygel.RootDeviceFactory {
                                         plugin.title);

         if (plugin.description != null) {
-            device_element->new_child (null,
-                                       "modelDescription",
-                                       plugin.description);

  i-e new_child() was called so a new 'modelDescription' node was
added to description XML on each rygel start-up.

> For the rest of 206f019..f6bfed4, I think I'm okay with it, but the
> renames make it hard to see if there was any change in the xml files.
> Even with git diff -M :/ So I'll give a first approval.

  There is no change in the renamed XML files IIRC.

-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124