Re: Some code changes wanted in Rygel

["Zeeshan Ali (Khattak)" <zeenix gmail com>]

On Mon, Sep 27, 2010 at 6:30 PM, Vincent Untz <vuntz gnome org> wrote:
> Le lundi 27 septembre 2010, à 18:15 +0300, Zeeshan Ali (Khattak) a écrit :
>> On Mon, Sep 27, 2010 at 5:39 PM, Andre Klapper <ak-47 gmx net> wrote:
>> > Am Montag, den 27.09.2010, 17:06 +0300 schrieb Zeeshan Ali (Khattak):
>> >> Hi again,
>> >>
>> >> On Mon, Sep 27, 2010 at 4:27 PM, Zeeshan Ali (Khattak) <zeenix gmail com> wrote:
>> >> >
>> >> >  So I modify my request to only include the following commits:
>> >> >
>> >> > 206f019..f6bfed4, 42a0f7b and f0b0127.
>> >>
>> >>   While you ponder about this, our tester found a much bigger issue:
>> >> our preferences UI was still using gtk+-3.0 Vala API (though it used
>> >> the correct C headers/library). I just fixed that in git master and
>> >> you can imagine why I'm telling you all this. :)
>> >
>> > Separate request email with separate link to code change, please.
>>
>>  Done!
>>
>>   Also pushed d26e9b4, 3d05345 and e64b932 that fixes dist issues
>> introduce by those XML file changes I requested for merge so if you
>> approve those changes, I'll assume these are implicitly approved with
>> those.
>
> I think d26e9b4 is wrong: $(xml_DATA) shouldn't be distributed if
> the files are generated anyway.

  Its not adding $(xml_DATA) but rather $(xml_in_files). I'll later
remove the $(xml_DATA) from dist unless you want me to do that
already.

-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124