Re: Some code changes wanted in Rygel

[Vincent Untz <vuntz gnome org>]

Le lundi 27 septembre 2010, à 09:30 +0200, Kjartan Maraas a écrit :
> sø., 26.09.2010 kl. 23.52 +0300, skrev Zeeshan Ali (Khattak):
> >   All these changes are to fix these 2 bugs:
> > 
> > https://bugzilla.gnome.org/show_bug.cgi?id=626196
> > https://bugzilla.gnome.org/show_bug.cgi?id=629378 (this patch was
> > reviewed by Andre Klapper for me).
> > 
> 
> Then I guess it's the first of those I don't really understand yet. What
> do the XML files do? Configuration for various models? Define some
> protocol to talk with them? What does the change to them do? What are
> the risks involved in approving this patch?
> 
> Just some more info to make it easier for the release team to make a
> decision :-)

I agree with Kjartan: it's really hard to approve a range of commits
like this, especially since:

 - there's at least one unrelated fix ("media-export: Add null checks to
   standard XDG folders")
 - there are some commits that don't matter at all (update git ignore
   list)

I'm +1 for the last commit (make .desktop file translatable), but you'll
need to tell gnome-i18n about this -- it's a shame this happens so late,
since it won't give a lot of time to translators :/

My understanding is that the first three commits go together. How
critical are those changes? How many devices will fail to work with
rygel?

Vincent

-- 
Les gens heureux ne sont pas pressés.