Re: [PATCH] ostbuild: don't work on the real repository for local URIs



2012/8/1 Colin Walters <walters verbum org>:
> On Tue, 2012-07-31 at 18:56 +0200, Giovanni Campagna wrote:
>> This
>> avoids patching ending up in the upstream repository or conflicting
>> with non-committed work.
>
> The local: key working this way was so you wouldn't have to commit
> local work just to build it.

Meh... GIT commits are cheap, and not committing before an automated
build is a risk (or at least, it is with jhbuild, as that updates and
checkouts the remote branch, ostbuild probably doesn't do that unless
it's in the snapshot)

> And even more than that, it doesn't clean _build in the checkout, so you
> get incremental builds (you can of course "git clean -dfx" as you wish
> get a full clean build).
>
> It's all about the edit-compile-debug cycle, in this case speeding
> up "edit-compile" to be as thin/fast as conceivably possible.
>
> I see the point of your patch - I'm guessing that you're using
> the same source directory for gnome-ostree hacking as for
> jhbuild hacking.  Personally I use two separate ones, which
> does help me avoid conflicts with jhbuild.

Well, I don't want to maintain two repositories with my branches on it
(plus the ones in github). But if that is the expected workflow, ok.

> Couldn't you get the effect you want by just changing the repository URI
> to git:file:///home/gcampax/src/modulename ?

That (or a shorthand in vcsconfig) works too!

Thanks, patch withdrawn

Giovanni


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]