Re: [orca-list] orca does not say the last line empty

[Jérémy PREGO <jeremy pregonetwork net>]

hello,

I confirm the fix.

thank !

Jerem
Le 02/07/2018 à 00:01, Joanmarie Diggs a écrit :
> Thanks Samuel. I've gone ahead and merged it to facilitate testing.
> --joanie
>
> On 07/01/2018 05:41 PM, Samuel Thibault wrote:
> > Hello,
> >
> > Joanmarie Diggs, le dim. 01 juil. 2018 09:38:53 -0400, a ecrit:
> > > I can confirm this regression. Reverting your fix for the braille
> > > backspacing issue fixes the regression. Mind taking a look and providing
> > > a patch which restores the original functionality (Orca should say
> > > blank/empty on the blank/empty line.)?
> > I have pushed to https://gitlab.gnome.org/GNOME/orca/merge_requests/5 a
> > fix. It is made of two commits: one which reverts the getTextLineAtCaret
> > changes, and the second which re-implements it, but keeping all offsets
> > separate, and only renaming caretOffset into fixedTargetOffset. That
> > should avoid side effects, at least it avoids this one (which was due to
> > the text.caretOffset == text.characterCount test being wrongly changed
> > by my patch).
> >
> > Samuel