Re: [orca-list] What meaning following commits into master branch?

[Hammer Attila <hammera pickup hu>]

Hy Joanie,

So, if I understand you right, will be possible doing following changes 
future with Orca side:
1. Will be you removing following code parts in src/orca/orca.py:
def quitOrca(script=None, inputEvent=None):
    """Quit Orca. Check if the user wants to confirm this action.
    If so, show the confirmation GUI otherwise just shutdown.

    Returns True to indicate the input event has been consumed.
    """

    shutdown()

    return True

2. Will be you remove the Quit command binding from 
src/orca/scripts/default.py:
        self.inputEventHandlers["shutdownHandler"] = \
            input_event.InputEventHandler(
                orca.quitOrca,
                _("Quits Orca"))

So, after this changes, only possible quitting or restart Orca after 
quit with GNOME upstream toggling screen reader binding possibility, 
with possible changing any time the user. Matter only if the user not 
known yet the builtin keystroke if first time using the new GNOME 3.8 
release, but possible looking this with GNOME Control Center Keyboard 
preference pane the shortcuts page, with Accessibility category. 
Advantage this change to one command possible to quit orca and equals 
command possible to start Orca again. For example, this command possible 
central associate an easy remember keystroke, for example SUPER+S 
(screen reader), SUPER+O (Orca) keystroke. Until GNOME3 fallback session 
not dropped, for example the SUPER+S keystroke will be conflicting with 
GNOME3 Indicator Applet builtin keybinding. Need using an one hand 
possible pressing keystroke to not producing difficulty to activate this 
keystroke if an user have unfortunately only one hand. After perhaps 
GNOME Fallback session are dropped, the SUPER+S keystroke is I think 
absolute free.

With you wrote change possibility (unbound the Orca+q binding, but 
keeping the quit command) is a better alternative, because any Orca user 
possible associate the old keystroke with Orca Preferences dialog and 
quit only with Orca this keystroke. This situation only need modifying 
the src/orca/scripts/default.py file, and need modifying only few code 
lines, without larger risks.

Sorry the long answer, I absolute sure will be you choose the best 
possibility future, depending the upstream GNOME 3.8 development version.
I don't no:
When for example Ubuntu 13.04 ship again a mixed GNOME 3.6 version and 
an Orca latest upstream version, how will be works this changes?

Attila