Re: Orca patches from Ubuntu

[Rich Burridge <Rich Burridge Sun COM>]

Henrik Nilsen Omma wrote:
> Right. I wonder a bit about the advice from the HIG there. If you 
> change something and then press Apply how do you then close the window 
> without loosing you changes? 

You could "click" on the Cancel button or you could click on the X dismiss
window item in the titlebar (not sure if that one is accessible via the 
keyboard) or
you could "click" on the OK button and the same changes would be applied
again. The first one seems to be best way to go.

> The HIG suggests that Cancel should undo everything, even changes made 
> before pressing Apply (so it's an Undo and Cancel button really -- is 
> that the way the Cancel button now behaves?). 

Not by my understanding of it (or the way I've implemented it in Orca).
Cancel will just dismiss the Preferences dialog window. It doesn't adjust
or save any settings.

> I guess it's OK if you have an OK button in addition to an Apply 
> button because then you can apply and press OK to close.

Right.

> Cool. We'll try to harmonise as best we can. We just made these 
> changes yesterday here as well, and in fact they are not in our 
> official releases yet either.

Excellent. Thanks.

PS: I update bug #354689 with a comment too.
     http://bugzilla.gnome.org/show_bug.cgi?id=354689