Re: [PATCH 1/1] contrib/rpm: add comment to NetworkManager.conf file

[Thomas Haller <thaller redhat com>]

On Thu, 2015-04-16 at 09:49 -0500, Dan Williams wrote:
> On Thu, 2015-04-16 at 14:51 +0200, Thomas Haller wrote:
> > ---
> >  contrib/fedora/rpm/NetworkManager.conf | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> >
> > diff --git a/contrib/fedora/rpm/NetworkManager.conf b/contrib/fedora/rpm/NetworkManager.conf
> > index 88b7cec..d0d0d3f 100644
> > --- a/contrib/fedora/rpm/NetworkManager.conf
> > +++ b/contrib/fedora/rpm/NetworkManager.conf
> > @@ -1,2 +1,12 @@
> > +# Configuration file for NetworkManager.
> > +# See "man 5 NetworkManager.conf" for details
> > +#
> > +# The directory /etc/NetworkManager/conf.d/ can contain
> > +# configuration snippets that are installed by some
> > +# packages. Those snippets overwrite the configuration
>
> I would say "override" instead of "overwrite".
>
> > +# from this main file.
> > +# To overwrite a configuration from conf.d/ add yet another
>
> Here too, and possibly drop the 'yet' since that implies "too many", as
> in "yet another blade of grass in this field" :)
>
> > +# configuration snippet with a name sorted last (99-my-config).
>
> Config snippets have to end with ".conf", according to
> _get_config_dir_files().
>
> Dan
>
> > +
> >  [main]
> >  plugins=ifcfg-rh,ibft

Thanks,

merged a modified version:
http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=36fc5cac83c9f1ba35d83ecfb163ba50eea169e1

Thomas

Attachment: signature.asc
Description: This is a digitally signed message part