On Thu, 2014-08-21 at 08:26 -0700, dwk wrote:
Thanks for the patch, it looks good. On 20/08/14 09:56 AM, Thomas Haller wrote:On Tue, 2014-08-19 at 23:25 -0700, d wk wrote:I suppose it may be a security risk to allow plugin files from any user (even though the plugin directory should have restrictive permissions); in that case, perhaps files owned by uid 0 or the current user should be allowed.the "current user" is always root, because you cannot run NM as non-root.True, but I can install it as a local user to run tests (or I used to be able to, before this change). It seems like a reasonable thing to want to do, especially when playing around with multiple NM versions.
After installing as non-root, I think you can do *everything* except running NM itself (due to before mentioned problem) -- including running tests (`make check`). Is that correct, or did you run into any other issues?
The
reason I didn't want to run ``make install' as root is because the
install actually tries to delete and re-create the following file:
/lib/udev/rules.d/77-nm-olpc-mesh.rules
This happens even when a prefix is set. I didn't want to mess up my
local known-good install of NetworkManager, so I ran ``make install -k''
as my local user instead (so the install succeeds, with the exception of
modifying /lib).
So perhaps another fix is needed here, to fix the configure scripts in
case a local prefix is specified; or add a flag to configure to allow
local installs of NetworkManager (which would disable modifying /lib and
maybe disable the check-if-file-owned-by-root check for plugins). I
think the documentation should describe how to run multiple NM versions.
You can overwrite the UDEV dir (which defaults to /lib/udev). Just ./configure --prefix=/tmp/NM --with-udev-dir=/tmp/NM/lib/udev ... Does that solve your problem? Thomas
Attachment:
signature.asc
Description: This is a digitally signed message part