On Tue, 2014-08-19 at 23:25 -0700, d wk wrote:
@@ -2022,8 +2020,10 @@ load_device_factories (NMManager *self)
char **paths;
paths = read_device_factory_paths ();
- if (!paths)
+ if (!paths) {
+ nm_log_warn (LOGD_HW, "no device factory paths found,
will not load plugins");
return;
+ }
I also think, there should be no warning that there are no plugins. You are expected to run NM just fine without device plugins (say, if you don't need them).
for (path = paths; *path; path++) {
GError *error = NULL;
I suppose it may be a security risk to allow plugin files from any user
(even though the plugin directory should have restrictive permissions);
in that case, perhaps files owned by uid 0 or the current user should be
allowed.
the "current user" is always root, because you cannot run NM as non-root. Thomas
Attachment:
signature.asc
Description: This is a digitally signed message part