Re: [PATCH] Add libgsystem as a git submodule

[Pavel Simerda <psimerda redhat com>]

> From: "Dan Winship" <danw gnome org>
>
> > > autogen.sh properly gets libgsystem. However it seems libgsystem simply
> > > uses
> > > latest GLib bits. I guess it should not if it can be avoided, because it
> > > spoils its usability.
> > > And that is the case for NetworkManager (that is just happy with glib
> > > 2.32).
> > >
> > > libgsystem now uses these symbols that require glib>=2.34:
> > > * g_mapped_file_get_bytes (GMappedFile *file)
> > > * g_spawn_check_exit_status()
> > > * and G_SPAWN_EXIT_ERROR, G_SPAWN_SEARCH_PATH_FROM_ENVP
> > >
> > > Making a compatibility definition for them will allow compilation.
> >
> > Would it be a problem to bump the requirement to 2.34?
>
> Yes, we picked the current versions to work well with various distros.

Thanks.

> Are we planning to use anything in libgsystem besides the auto-free
> stuff?

No idea.

Colin, do you have any ideas for the NetworkManager codebase apart from the cleanup functions?

> If not, why don't we remove the submodule and just copy in the
> header with the relevant macros for now?

Or maybe we could make the build system only choose relevant parts from libgsystem. I hope we don't have to 
revert it the second time and would rather have the bumped dependency for a couple of days. Maybe Colin comes 
up with some neat solution.

Cheers,

Pavel