Re: [PATCH] Add libgsystem as a git submodule

----- Original Message -----
From: "Jirka Klimes" <jklimes redhat com>
To: "Dan Williams" <dcbw redhat com>
Cc: "Pavel Simerda" <psimerda redhat com>, "Colin Walters" <walters verbum org>, networkmanager-list gnome 
"danw" <danw gnome org>
Sent: Friday, May 17, 2013 9:37:29 AM
Subject: Re: [PATCH] Add libgsystem as a git submodule

On Thursday 16 of May 2013 14:09:32 Dan Williams wrote:
On Thu, 2013-05-16 at 04:53 -0400, Pavel Simerda wrote:
From: "Colin Walters" <walters verbum org>

On Mon, 2013-05-06 at 12:50 -0500, Dan Williams wrote:
On Fri, 2013-04-26 at 16:42 -0400, Colin Walters wrote:
And change src/main.c to use the local allocation macros.  This
results in much cleaner code, as one can see from the diff.

Because libgsystem is designed for nonrecursive make, it fits best
the current recursive setup if we build . first.  This will be a
nicer when we switch NM to a nonrecursive setup.

 .gitmodules     |    3 +++     |    7 +++++++
 libgsystem      |    1 +
 src/ |    2 ++
 src/main.c      |   50
 5 files changed, 25 insertions(+), 38 deletions(-)
 create mode 100644 .gitmodules
 create mode 160000 libgsystem

Patch looks good to me; Pavel, I'll assume you acked it too, given
had objections last time?

Any thoughts, Pavel?

Patch looks good to me. It might be good to have Dan Winship's (Cc) ack
too, as he recently modified the build system files and might have some
comments or suggestions.
libgsystem pushed; everyone re-run to get the new module
bits.  Otherwise it'll fail pretty quick.

Dan properly gets libgsystem. However it seems libgsystem simply uses
latest GLib bits. I guess it should not if it can be avoided, because it
spoils its usability.
And that is the case for NetworkManager (that is just happy with glib 2.32).

libgsystem now uses these symbols that require glib>=2.34:
* g_mapped_file_get_bytes (GMappedFile *file)
* g_spawn_check_exit_status()

Making a compatibility definition for them will allow compilation.

Would it be a problem to bump the requirement to 2.34?


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]