Re: [PATCH] Add libgsystem as a git submodule

[Dan Williams <dcbw redhat com>]

On Thu, 2013-05-16 at 04:53 -0400, Pavel Simerda wrote:
> > From: "Colin Walters" <walters verbum org>
> > On Mon, 2013-05-06 at 12:50 -0500, Dan Williams wrote:
> > > On Fri, 2013-04-26 at 16:42 -0400, Colin Walters wrote:
> > > > And change src/main.c to use the local allocation macros.  This
> > > > results in much cleaner code, as one can see from the diff.
> > > >
> > > > Because libgsystem is designed for nonrecursive make, it fits best in
> > > > the current recursive setup if we build . first.  This will be a lot
> > > > nicer when we switch NM to a nonrecursive setup.
> > > > ---
> > > >  .gitmodules     |    3 +++
> > > >  Makefile.am     |    7 +++++++
> > > >  libgsystem      |    1 +
> > > >  src/Makefile.am |    2 ++
> > > >  src/main.c      |   50
> > > >  ++++++++++++--------------------------------------
> > > >  5 files changed, 25 insertions(+), 38 deletions(-)
> > > >  create mode 100644 .gitmodules
> > > >  create mode 160000 libgsystem
> > >
> > > Patch looks good to me; Pavel, I'll assume you acked it too, given you
> > > had objections last time?
> >
> > Any thoughts, Pavel?
>
>
> Patch looks good to me. It might be good to have Dan Winship's (Cc) ack too, as he recently modified the 
> build system files and might have some comments or suggestions.

libgsystem pushed; everyone re-run autogen.sh to get the new module
bits.  Otherwise it'll fail pretty quick.

Dan