Re: [PATCH] icera: increase timeout for +CFUN=4

[Ben Chan <benchan chromium org>]

Thanks. yes, it's a ridiculously long timeout. I wouldn't be too surprise that it's a firmware issue. Worse yet, it's not certain that we will have a fix.

I've reported the issue to the chipset and modem manufacturer, but haven't yet got a response. I'll submit a better solution as soon as I find one.

- Ben

On Sat, Sep 8, 2012 at 1:28 AM, Aleksander Morgado <aleksander lanedo com> wrote:

On 09/08/2012 12:10 AM, Dan Williams wrote:
> On Fri, 2012-09-07 at 14:15 -0700, Ben Chan wrote:
>> diff --git a/plugins/icera/mm-broadband-modem-icera.c b/plugins/icera/mm-broadband-modem-icera.c
>> index e429a2f..07c4b38 100644
>> --- a/plugins/icera/mm-broadband-modem-icera.c
>> +++ b/plugins/icera/mm-broadband-modem-icera.c
>> @@ -810,7 +810,12 @@ modem_power_down (MMIfaceModem *self,
>>       * keeps access to the SIM */
>>      mm_base_modem_at_command (MM_BASE_MODEM (self),
>>                                "+CFUN=4",
>> -                              3,
>> +                              /* The modem usually completes +CFUN=4 within 1-2 seconds,
>> +                               * but sometimes takes a ridiculously long time (~30-35 seconds).
>> +                               * It's better to have a long timeout here than to have the
>> +                               * modem not responding to subsequent AT commands until +CFUN=4
>> +                               * completes. */
>> +                              40,
>>                                FALSE,
>>                                callback,
>>                                user_data);
>
> Really?  Can you get any guidance from Samsung on *why* it's taking 35
> seconds to power down?  That is quite ridiculous, and I have a hard time
> imagining how that's not a firmware bug...
>

I pushed it like this for now; but we should really get an idea of why
it happens.

--
Aleksander