Re: [PATCH] icera: increase timeout for +CFUN=4

[Dan Williams <dcbw redhat com>]

On Fri, 2012-09-07 at 14:15 -0700, Ben Chan wrote:
> diff --git a/plugins/icera/mm-broadband-modem-icera.c b/plugins/icera/mm-broadband-modem-icera.c
> index e429a2f..07c4b38 100644
> --- a/plugins/icera/mm-broadband-modem-icera.c
> +++ b/plugins/icera/mm-broadband-modem-icera.c
> @@ -810,7 +810,12 @@ modem_power_down (MMIfaceModem *self,
>       * keeps access to the SIM */
>      mm_base_modem_at_command (MM_BASE_MODEM (self),
>                                "+CFUN=4",
> -                              3,
> +                              /* The modem usually completes +CFUN=4 within 1-2 seconds,
> +                               * but sometimes takes a ridiculously long time (~30-35 seconds).
> +                               * It's better to have a long timeout here than to have the
> +                               * modem not responding to subsequent AT commands until +CFUN=4
> +                               * completes. */
> +                              40,
>                                FALSE,
>                                callback,
>                                user_data);

Really?  Can you get any guidance from Samsung on *why* it's taking 35
seconds to power down?  That is quite ridiculous, and I have a hard time
imagining how that's not a firmware bug...

Dan