Re: review request: pavlix/distro



On Sat, 2012-10-27 at 19:47 -0400, Pavel Simerda wrote:
> Hi all,
> 
> I would like to recieves comments on my 'pavlix/distro' branch that consists
> of three patches aiming towards distro-agnostic build system.
> 
> http://cgit.freedesktop.org/NetworkManager/NetworkManager/log/?h=pavlix/distro
> 
> dcbw: I recall that you wanted to build all plugins. The last patch enables
> you to do that but defaults to the current behavior.
> 
> Distribution maintainers: It would be nice to actually remove all initscripts
> that you don't plan to use. The second patch removes automatic installation of
> initscripts but keeps them in the tree.

Looks good except for one thing: the --with-netconfig help text still
refers to --with-suse-netconfig.  If you fix that, merge it.  Thanks!

Dan



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]