Re: [PATCH] core: add internet connectivity check

[Marcel Holtmann <marcel holtmann org>]

Hi Thomas,

> i just want to summarize the discussion about the response handling so
> we can decide which solution we want to use.
> mentioned solutions are:
> 
> 1) check http status-response 204 (or any other) (chromiumos method)
> 2) check content for a specific http header (connman method)
> 3) check start of content (implemented in patch V3)
> 4) check complete content
> 5) check http status-response 200 (creates false positives for hotspots)
> 6) check content with a regex (tie us into a specific regex lib)
> 
> 5+6 are already declined.
> 
> i prefer solution 3 because it's more flexible than 1) and produce fewer
> traffic than 2).

actually 2) would produce fewer traffic than 3) since the HTTP headers
are transmitted before the content.

If you just want some stupid check, then looking at the headers is
simpler since otherwise you have to deal with HTTP 1.0 vs 1.1 and have
to have support for chunked encoding.

However if your long term goal is WISPr support, then you have to look
at the whole page anyway. There is no guarantee that the WISPr XML is at
the beginning. Some providers actually just attach it to the end.

Regards

Marcel