Re: [PATCH] core: add internet connectivity check



On 11/16/2011 01:19 AM, Dan Williams wrote:
>> ./NetworkManager --no-daemon --log-level=DEBUG --log-domains=CORE
>> --connectivity-uri=http://toabctl.de
>> --connectivity-response="<title>toabctl.de</title>"
> 
> Pretty much what I was thinking about, but I wonder what we should do
> for the expected response.  I'm not sure a regex is the right way to go
> at the moment because regex libraries differ in syntax and that might
> tie us into a specific one.  But regex is powerful :)  I think maybe for
> the moment we should just specify that it's a string match.  Then later
> when more intelligently handling hotspot perhaps we'll do regexes.

My theory on this was to always request a plain-text file, and then if
you get back anything HTML, you automatically know it's wrong.

-- Dan



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]