Re: ANN: Release of NetworkManager 0.8.996 (0.9.0-beta2)

[Mikhail Efremov <mikhefr gmail com>]

On Wed, 16 Mar 2011 01:49:18 -0500 Dan Williams wrote:
> On Mon, 2011-03-14 at 21:30 +0300, Mikhail Efremov wrote:
> > On Fri, 11 Mar 2011 11:25:20 -0600 Dan Williams wrote:
> > > States are renumbered since there are now 3 connected states (LOCAL,
> > > SITE, GLOBAL) depending on the network connectivity.  There's also a new
> > > DISCONNECTING state that will eventually facilitate Debian's
> > > long-standing request for a "pre-down" event.  There's also space
> > > between the states in case in the future we want to add more without
> > > breaking API.
> > 
> > Thanks for the answer, but I still do not understand why it just does
> > not add the new states at the end of the enum. But since you have
> > already submitted the patches, I think it's too late to change anything.
> 
> Mainly to keep consistency, provide some space for later additions in
> the middle of the list, and to allow clients to use > and < when doing
> comparisons on states.  IE:
> 
> if (state > DISCONNECTED)
> 
> etc.

Because some applications still use the deprecated "StateChange" signal
and should be fixed, then maybe you're right and this is a good reason
to change these values ​​at the same time for more clear and consistent
code in the future.

-- 
WBR, Mikhail Efremov