Re: ANN: Release of NetworkManager 0.8.996 (0.9.0-beta2)

[Dan Williams <dcbw redhat com>]

On Fri, 2011-03-11 at 17:21 +0300, Mikhail Efremov wrote:
> On Fri, 11 Mar 2011 14:58:09 +0100 Michael Biebl wrote:
> > Am 11.03.2011 14:26, schrieb Mikhail Efremov:
> > > On Fri, 11 Mar 2011 10:28:58 +0100 Michael Biebl wrote:
> > >> Am 11.03.2011 09:49, schrieb Michael Biebl:
> > >>>
> > >>> Been testing the 0.8.996 packages. Looking quite ok so far.
> > >>>
> > >>> Some impressions:
> > >>>
> > >>
> > >> The online/offline (D-Bus) API seems to be broken.
> > >> firefox always starts in offline mode now when using
> > >> toolkit.networkmanager.disable false
> > > 
> > > Values of NM states have been changed. See commits ec115ed4 and
> > > 11a68133. So all applications which uses that API should be rebuilded.
> > > But firefox uses its own hardcoded constants (see
> > > toolkit/system/dbus/nsNetworkManagerListener.cpp).
> > 
> > I don't think NM should break that specific D-Bus API and be backwards compatible.
> 
> Yes, I agree with you. I see no reasons to change these values, except
> for cosmetic. But maybe Dan will explain why this was done.

Patches have been submitted for most of the affected programs that I
could find (including Firefox).  For any others, the changes are quite
minimal and the patch is able to preserve backwards compatibility in the
same code.  That's only possible because the old states are all < 10,
which is one reason the new states are numbered the way they are.

States are renumbered since there are now 3 connected states (LOCAL,
SITE, GLOBAL) depending on the network connectivity.  There's also a new
DISCONNECTING state that will eventually facilitate Debian's
long-standing request for a "pre-down" event.  There's also space
between the states in case in the future we want to add more without
breaking API.

Dan