Re: [PATCH] Remove arping

[Dan Williams <dcbw redhat com>]

On Thu, 2008-05-29 at 14:55 +0200, Michael Biebl wrote:
> Michael Biebl wrote:
> > Benoit Boissinot wrote:
> >> On Thu, May 29, 2008 at 1:15 AM, Michael Biebl <biebl debian org> wrote:
> >>> Dan Williams schrieb:
> >>>> On Fri, 2008-05-23 at 15:16 +0200, Michael Biebl wrote:
> >>>>> Hi,
> >>>>>
> >>>>> after todays merges of Benoit's patches to use libnl directly instead of
> >>>>> ip, I was wondering why nm_generic_device_flush_ip4_routes_with_iface in
> >>>>> src/backends/NetworkManagerGeneric.c still calls ip and wasn't ported to
> >>>>> use libnl.
> >>>> Because there were issues with that patch and VPN connections that I'm
> >>>> sending more info to Benoit about.  The routing table is different with
> >>>> that code than without it, and caused any traffic over VPN to return
> >>>> EINVAL (even a ping to 4.2.2.1).
> >>>>
> >>>> But the plan is to fix that up and kill usage of /sbin/ip entirely.
> >>>>
> >>> I guess with r3698, it's safe to remove the configure check for ip now.
> >>> Patch attached.
> >>>
> >> And the attached patches are needed for further cleanups too.
> >>
> > 
> > Good catch.
> > On top of that, we should also remove the references on arping, which 
> > are no longer necessary.
> > 
> 
> Argh, this time, with patch...

Committed, thanks! r3702

Dan