Re: dependency on ip still necessary?



Dan Williams schrieb:
> On Fri, 2008-05-23 at 15:16 +0200, Michael Biebl wrote:
>> Hi,
>>
>> after todays merges of Benoit's patches to use libnl directly instead of 
>> ip, I was wondering why nm_generic_device_flush_ip4_routes_with_iface in 
>> src/backends/NetworkManagerGeneric.c still calls ip and wasn't ported to 
>> use libnl.
> 
> Because there were issues with that patch and VPN connections that I'm
> sending more info to Benoit about.  The routing table is different with
> that code than without it, and caused any traffic over VPN to return
> EINVAL (even a ping to 4.2.2.1).
> 
> But the plan is to fix that up and kill usage of /sbin/ip entirely.
> 

I guess with r3698, it's safe to remove the configure check for ip now.
Patch attached.

Cheers,
Michael


-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?
Index: configure.in
===================================================================
--- configure.in	(Revision 3698)
+++ configure.in	(Arbeitskopie)
@@ -285,19 +285,6 @@
 fi
 AC_SUBST(DBUS_SYS_DIR)
 
-# ip binary path
-AC_ARG_WITH(ip, AS_HELP_STRING([--with-ip=/path/to/ip], [path to ip])) 
-if test "x${with_ip}" = x; then
-  AC_PATH_PROG(IP_BINARY_PATH, ip, [], $PATH:/sbin:/usr/sbin)
-  if ! test -x "$IP_BINARY_PATH"; then
-	AC_MSG_ERROR(iproute2 was not installed.  See http://linux-net.osdl.org/index.php/Iproute2)
-  fi
-else
-  IP_BINARY_PATH="$with_ip"
-fi
-AC_DEFINE_UNQUOTED(IP_BINARY_PATH, "$IP_BINARY_PATH", [Define to path of ip binary])
-AC_SUBST(IP_BINARY_PATH)
-
 # PPPD
 AC_CHECK_HEADERS(pppd/pppd.h,,
   AC_MSG_ERROR(couldn't find pppd.h. pppd development headers are required.))

Attachment: signature.asc
Description: OpenPGP digital signature



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]