Re: [PATCH] Remove arping

Michael Biebl wrote:
Benoit Boissinot wrote:
On Thu, May 29, 2008 at 1:15 AM, Michael Biebl <biebl debian org> wrote:
Dan Williams schrieb:
On Fri, 2008-05-23 at 15:16 +0200, Michael Biebl wrote:

after todays merges of Benoit's patches to use libnl directly instead of
ip, I was wondering why nm_generic_device_flush_ip4_routes_with_iface in
src/backends/NetworkManagerGeneric.c still calls ip and wasn't ported to
use libnl.
Because there were issues with that patch and VPN connections that I'm
sending more info to Benoit about.  The routing table is different with
that code than without it, and caused any traffic over VPN to return
EINVAL (even a ping to

But the plan is to fix that up and kill usage of /sbin/ip entirely.

I guess with r3698, it's safe to remove the configure check for ip now.
Patch attached.

And the attached patches are needed for further cleanups too.

Good catch.
On top of that, we should also remove the references on arping, which are no longer necessary.

Argh, this time, with patch...


Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?
Index: src/backends/NetworkManagerArch.c
--- src/backends/NetworkManagerArch.c	(Revision 3701)
+++ src/backends/NetworkManagerArch.c	(Arbeitskopie)
@@ -54,8 +54,6 @@
 #include "interface_parser.h"
 #include "nm-utils.h"
-#define ARPING "/usr/sbin/arping"
  * nm_system_init
Index: src/backends/NetworkManagerDebian.c
--- src/backends/NetworkManagerDebian.c	(Revision 3701)
+++ src/backends/NetworkManagerDebian.c	(Arbeitskopie)
@@ -43,8 +43,6 @@
 #include "interface_parser.h"
 #include "nm-utils.h"
-#define ARPING "/usr/sbin/arping"
  * nm_system_init

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]