pppoe, 3g question and possible bug

["charlyliu" <charlyliu linpus com>]

Hi all,

I was trying to use the pppoe features. I create a connection in gconf. But I don't really know what it should have. Now I only put the directory ppp, copying the settings of a vpn connection, the directory pppoe with the username, password and service key and the directory connection with the type = pppoe. 

Of course, I suppose that password wouldn't be there but I don't know where to put it right now.

After created the connection settings manually, I can activated the connection with the applet but it returns an error and crashes NM. I debugged and I saw that in function nm_ppp_manager_start, when was going to fill the ppp_settings with the function pppoe_fill_defaults, it couldn't assign the default values to the settings because it didn't exists. 
I added these lines and at least it begins pppd. 

+++ ../NetworkManager/src/ppp-manager/nm-ppp-manager.c  2008-04-02 17:38:16.000000000 +0800
@@ -636,8 +636,12 @@
        ppp_setting = NM_SETTING_PPP (nm_connection_get_setting (connection, NM_TYPE_SETTING_PPP));
        pppoe_setting = (NMSettingPPPOE *) nm_connection_get_setting (connection, NM_TYPE_SETTING_PPPOE);

-       if (pppoe_setting)
+       if (!ppp_setting)
+               ppp_setting = (NMSettingPPP *) nm_setting_ppp_new();
+
+       if (pppoe_setting){
                pppoe_fill_defaults (ppp_setting);
+       }

        ppp_cmd = create_pppd_cmd_line (ppp_setting, pppoe_setting, device, err);
        if (!ppp_cmd)


About 3G, I could connect but when I disconnected I saw that a pppd process was still alive and I couldn't kill it unless I stop NM.

Last question, because I'm a newbie, I don't really understand how NM creates connections and the respectives settings. For example at applet-device-wired.c in function wired_get_secrets, I can't see how it knows if the connection is 8021x or pppoe. When do you tell the connection is that type.

Sorry about my english and I hope I can help the project with my tests.

Charly Liu