Re: [PATCH] Compile and install the ifcfg plugin proper

[Dan Williams <dcbw redhat com>]

On Sun, 2007-12-16 at 18:53 +0100, Michael Biebl wrote:
> Dan Williams schrieb:
> > On Tue, 2007-12-04 at 18:51 +0100, Michael Biebl wrote:
> >> Dan Williams schrieb:
> >>
> >> So now, as a pppd plugin it shouldn't be $(libdir)/NetworManager, but
> >> the pppd plugin path.
> 
> >> A completely different solution would be to provide a
> >> --with-pppd-plugindir configure option and rely on the distributor to
> >> correctly set it on compilation.
> >>
> >> What would you prefer?
> > 
> > --with-pppd-plugindir; automatic detection is problematic in many cases
> > and using the automatic detection, packagers can't reliably ensure a
> > consistent build (gstreamer autodetecting which plugins to build based
> > on whether or not you have the deps is the worst case here).  In any
> > case, even if there was automatic detection, I'd like a manual override,
> > so the --with-* option has to be there in either case :)  Looking
> > forward to the patch...
> > 
> 
> Hi Dan,
> 
> even if it took a bit longer, here is the promised patch for the pppd
> plugin. It looks like autoconf doesn't easily allow to grab the output
> from a test program, so I went with the --with-pppd-plugin-dir approach.
> If it's not passed to configure, I fallback ot $(libdir)/pppd/2.4.4.
> 
> While at it, I cleaned up configure.in a bit, and replaced obsolete
> macros: AC_HELP_STRING -> AS_HELP_STRING, AM_CONFIG_HEADER ->
> AC_CONFIG_HEADERS, AC_OUTPUT -> AC_CONFIG_FILES+AC_OUTPUT.
> And just for the sake of consistency, I renamed --with-dbus-sys to
> --with-dbus-sys-dir.
> 
> Please review and apply.

Thanks!  Applied.

Dan