Re: [PATCH] Compile and install the ifcfg plugin proper



Dan Williams schrieb:

> 
> r3131; needed to update the ppp-manager's idea of where the pppd plugin
> was though.  Where do most pppd plugins go?  Should the NM pppd plugin
> go there, or in $(libdir)/NetworkManager/ ?
> 

TBH, I didn't know that the ppp-manager lib was intended as a pppd
plugin. It only seemed obvious to not install it into $(libdir)

So now, as a pppd plugin it shouldn't be $(libdir)/NetworManager, but
the pppd plugin path.
Unfortunately there is no convenient way to determine it (at least I
don't know one). On Debian the pppd plugin path is /usr/lib/pppd/2.4.4,
but given that a new pppd version is released, this path will obviously
change.

A solution could be to write a configure check, which test-compiles and
executes the following

#define PLUGIN
#define DESTDIR "/usr"

#include <pppd/pppd.h>
#include <pppd/pathnames.h>

int main()
{
        printf("%s\n", _PATH_PLUGIN);
        return 0;
}

I hardcoded DESTDIR to /usr. Maybe it would make sense to use $(prefix)
instead (could be interesting for the *BSDs).

A completely different solution would be to provide a
--with-pppd-plugindir configure option and rely on the distributor to
correctly set it on compilation.

What would you prefer?

Cheers,
Michael

-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

Attachment: signature.asc
Description: OpenPGP digital signature



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]