Re: [PATCH 0/9] Port to latest GTK+ 2 and gtkmm-2.4

[Dodji Seketeli <dodji seketeli org>]

Kalev Lember <kalevlember gmail com> a écrit:

> On 03/28/2011 01:20 PM, Dodji Seketeli wrote:

>> So that would mean us targeting gtk2 version 2.18 and gtkmm2' version
>> 2.18.
>> 
>> Are these too old?
>
> Yes, I would say so. For instance, GtkSpinner (which Nemiver's master
> now uses) emerged in gtk+ 2.20, so we are already past the point of
> supporting 2.18. I suppose we could add EphySpinner back and some
> #ifdefs to select it when gtk+ is too old ... but it feels like a step
> backwards.
>
> I think that supporting gtk+ 2.18 and gtk+ 3 in same code would result
> in way too many ifdefs all over the code, in particular because of the
> changes in gtksourceview API.
>
> How about instead branching off a gtk2 branch from the last commit
> before GtkSpinner landed? It'd be possible to do new 0.8.x releases from
> that branch, keeping it strictly bug-fix only. The branch might even be
> named '0.8'.

Okay.  This makes sense to me.  I wouldn't restrict the gtk2 branch to
bug-fix only, though.  If some patches from master are useful enough to
get in there, are reasonably independent from the version of GTK+ and if
someone has time and energy to do the work, I guess it might be
interesting to land them in the branch.

> And the master branch would be free to drop all the legacy cruft and
> would eventually become gtk3-only.

Agreed.

I'll cut the branch off ASAP, then.  Thanks for the feedback.

-- 
		Dodji