Re: [PATCH 0/9] Port to latest GTK+ 2 and gtkmm-2.4

[Kalev Lember <kalevlember gmail com>]

On 03/28/2011 01:20 PM, Dodji Seketeli wrote:
> Kalev Lember <kalevlember gmail com> a écrit:
>> Should we target the latest gtk2 / gtkmm-2.4, or perhaps the versions
>> that are in Debian stable, or something in between (Fedora 14, Ubuntu
>> 10.10)?
> 
> I think targeting Debian stable does make a lot of sense, as long it
> doesn't cause us too much hassle.  I would put Fedora/EPEL6 in the same
> bag, for selfish reasons as I maintain the Nemiver package in
> Fedora/EPEL6.  So that would mean us targeting gtk2 version 2.18 and
> gtkmm2' version 2.18.
> 
> Are these too old?

Yes, I would say so. For instance, GtkSpinner (which Nemiver's master
now uses) emerged in gtk+ 2.20, so we are already past the point of
supporting 2.18. I suppose we could add EphySpinner back and some
#ifdefs to select it when gtk+ is too old ... but it feels like a step
backwards.

I think that supporting gtk+ 2.18 and gtk+ 3 in same code would result
in way too many ifdefs all over the code, in particular because of the
changes in gtksourceview API.

How about instead branching off a gtk2 branch from the last commit
before GtkSpinner landed? It'd be possible to do new 0.8.x releases from
that branch, keeping it strictly bug-fix only. The branch might even be
named '0.8'.

And the master branch would be free to drop all the legacy cruft and
would eventually become gtk3-only.

-- 
Kalev