Re: Removing libgnome dependency

[Alexander Larsson <alexl redhat com>]

On Sat, 2008-10-04 at 15:59 +0200, Cosimo Cecchi wrote:
> On Sat, 2008-10-04 at 14:14 +0200, Cosimo Cecchi wrote:
> > On Fri, 2008-10-03 at 19:26 +0200, Cosimo Cecchi wrote:
> > 
> > > I am currently working on gnome_program, gnome_help, gnome_popup_menu
> > > and gnome_authentication_manager, will post a patch soon.
> > 
> > You can find my work so far in the attached patches.
> > I hopefully dropped all references to gnome_program, gnome_config,
> > gnome_authentication, gnome_color_picker and the use of the GNOME_*
> > class/type definition macros inside Nautilus.
> > I now plan to have a look at gnome_icon_entry and gnome_popup_menu; in
> > the meantime, is it OK to commit these to trunk?
> 
> Last follow-up for today:
> - removed gnome_popup
> - removed gnome_icon_entry
> - removed all the useless libgnome/* includes, (and even an uncatched
> old gnome-vfs one!)

Commited with a fix:

@@ -753,11 +751,11 @@ button_pressed_callback (GtkTreeView *treeview, GdkEventButton *event,
 		}
 
 		g_object_ref (view);
-		
-		gnome_popup_menu_do_popup_modal (view->details->popup,
-						 NULL, NULL, event, NULL,
-						 GTK_WIDGET (treeview));
-		
+
+		gtk_menu_popup (GTK_MENU (view->details->popup),
+				NULL, NULL, NULL, NULL,
+				event->button, event->time);
+

Crashes due to freed view->details->popup_file


Also, gnome_icon_entry is still used via eel_gnome_icon_selector_new.